-
Notifications
You must be signed in to change notification settings - Fork 109
Update Picard so that it uses v2 of WP-API #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Remove Picard's comment handling as WP-API is now capable of taking care of this. - Fix URLs where need be - Fix properties where need be
|
Although the way in which Picard handles routes is not satisfactory as far as I'm concerned. The commits in this PR update Picard purely so that it works with v2 of WP-API as it did with the first version. So I think this is ready for merge. I will focus on other improvements in other branches and PRs. Anyone fancy reviewing this? 😄 |
|
Maybe the first step should be agreeing which v2 of the REST API plugin to use; see #38 |
…rdPress.org plugin repo.
|
Hi guys, was this branch merged to master? I am still getting the error class wp_json_comments not found. |
|
Hi @AntonioAsr ! No, it doesn't look like v2 work was ever merged, and no-one at Automattic is actively working on it. It simply up here now as a demo of early exploration. |
|
Thanks for the early answer @kwight . It's a pity...the theme had an interesting navigation =( |
V2 of WP-API forms the basis of what will be going into core. It therefore makes sense that Picard is made compatible with it.