Demo Project: Convert Groups to Buildable Folder references#676
Open
andrewdmontgomery wants to merge 12 commits intotrunkfrom
Open
Demo Project: Convert Groups to Buildable Folder references#676andrewdmontgomery wants to merge 12 commits intotrunkfrom
andrewdmontgomery wants to merge 12 commits intotrunkfrom
Conversation
|
| App Name | Gravatar Prototype Build | |
| Build Number | 2148 | |
| Version | PR #676 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 0a7a1d7 | |
| Installation URL | 7m2ran1p333t8 |
Just a routine update before digging deeper into a build failure, see https://buildkite.com/automattic/gravatar-sdk-ios/builds/2135/steps?sid=0195d364-32bb-47c4-a10c-0da0a39806ce
Co-authored-by: Olivier Halligon <olivier@halligon.net>
2bffa51 to
0a7a1d7
Compare
Contributor
Author
|
This change caused us to stumble into a bug with fastlane. Fastlane will be fixing this. In the interim, we have a simple workaround in place (#681). Once Fastlane has a fix in place, we can update Fastlane, and revert that PR. In fact, we should revert most of that PR, but not all of it, since one commit actually fixes a typo (which would be a nice fix to keep). See that PR for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This makes two changes:
Gravatar-Demogroup/folder in the project to a "Buildable Folder reference". This simplifies and reduces commit churn of the project file.Buildable Folder References in Xcode 16
Xcode 16 introduced "Buildable Folder references":
With a Buildable Folder reference:
Note that any file added to this folder is automatically added to the target, even if the file is added from outside of Xcode.
Testing Steps
Gravatar-DemofolderCompile sourcesBuild Phase for theGravatar-DemotargetDemo/Gravatar-Demo.xcodeproj/project.pbxprojdoes NOT changeGravatar-Demofolder (you can duplicate one)Compile sourcesBuild Phase for theGravatar-DemotargetDemo/Gravatar-Demo.xcodeproj/project.pbxprojdoes NOT change