Simplify OpenAPI Generator#522
Merged
andrewdmontgomery merged 3 commits intorelease/3.0.0from Oct 22, 2024
Merged
Conversation
|
| App Name | ||
| Build Number | 1583 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 1ef109a | |
| App Center Build | Gravatar SDK Demo - UIKit #299 |
|
| App Name | ||
| Build Number | 1583 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-swiftui.prototype-build | |
| Commit | 1ef109a | |
| App Center Build | Gravatar SDK Demo - SwiftUI #298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Description
This simplifies our OpenAPI Generator setup, and borrows from the work done in #486:
generatecommand:docker run --rm openapitools/openapi-generator-cli:"v7.5.0" generateinstall-and-generateMakefile task has been removed, as it is no longer requiredmodels).openapi-generator-ignoreto selectively ignore which file/folders should be created--additional-optionsopenapi-generateactivity into theopeapidirectoryswift5generator supports outputing source files as a Swift Package. While we aren't using it as a Swift Package, using that folder structure feels more natural. So the generated source files are inSources. They are then rsynced to their final destinationNote
After this PR merges, we will want to delete the
openapi-generatordirectory in the root of the repo.This PR no longer requires or uses the
openapi-generatordirectory. That folder is currently ignored by git. But since we don't need this folder any more, this PR stops ignoring that folder.Testing Steps
make generate7.5.0) (only occurs the first time):Sources/Gravatar/OpenApi/Generatedshould be the usual changes to accesspackage --> publiclevels, which we are currently correcting by hand.