This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Open TermsOfService and PrivacyPolicy in a customTab#88
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements in-app browser functionality for Terms of Service and Privacy Policy links to keep users within the app context when viewing these documents.
- Adds CustomTabs support using the AndroidX browser library
- Updates Terms of Service and Privacy Policy link handlers to use in-app browser instead of external browser
- Introduces a new
openUrlInAppfunction that usesCustomTabsIntentfor in-app browsing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AboutAppDialog.kt | Updates link handlers to use CustomTabs and adds new in-app URL opening function |
| build.gradle.kts | Adds AndroidX browser dependency for CustomTabs functionality |
...lin/com/gravatar/app/homeUi/presentation/home/components/topbar/components/AboutAppDialog.kt
Show resolved
Hide resolved
hamorillo
force-pushed
the
hamorillo/GRA-630
branch
from
0c59ac2 to
9559c60
Compare
etoledom
approved these changes
Jul 29, 2025
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Working perfectly as described 🎉
Those links shouldn't leave the app, so use CustomTabs to open them inside the app.
hamorillo
force-pushed
the
hamorillo/GRA-630
branch
from
9559c60 to
4b2ac13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TermOfServiceandPrivacyPolicylinks should be opened in an in-app browser so the user doesn't leave the app context.Kapture.2025-07-29.at.12.54.28.mp4
Testing Steps
About this appdialogTermOfServiceandPrivacyPolicyare opened in an in-app browser.