Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Use Android App link for redirect URI#117

Merged
hamorillo merged 1 commit intotrunkfrom
hamorillo/GRA-711
Aug 20, 2025
Merged

Use Android App link for redirect URI#117
hamorillo merged 1 commit intotrunkfrom
hamorillo/GRA-711

Conversation

@hamorillo
Copy link

@hamorillo hamorillo commented Aug 20, 2025

Description

This PR migrates from the custom schema used for the OAuth redirection to use Android App Link.

The behaviour in the login flow should be identical from the users' point of view.

All the backend configuration is already done, so it should work smoothly.

Note: Don't forget to update your project secrets.

Testing Steps

❗ Test both debug and prototype build as we need to verify that both fingerprints are correct in the backend.

  • Verify that the app works as expected after the login (OAuth) flow. Sign out and sign in.
  • [Use Prototype Build] Verify that the app works as expected after the login (OAuth) flow. Sign out and sign in.

@hamorillo hamorillo requested a review from Copilot August 20, 2025 08:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the OAuth redirect URI handling from a custom scheme to Android App Links for improved security and user experience. The change enables automatic verification of deep links through the Android system.

  • Adds android:autoVerify="true" to the intent filter for automatic app link verification
  • Introduces proper URI path handling by adding OAUTH_REDIRECT_URI_PATH manifest placeholder
  • Refactors URI parsing logic to use Java's URI class instead of manual string splitting

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
loginUi/src/main/AndroidManifest.xml Enables auto-verification and adds path parameter for app links
loginUi/build.gradle.kts Refactors URI parsing to use proper URI class and extract path component
.configure Updates pinned hash reference for configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wpmobilebot
Copy link

wpmobilebot commented Aug 20, 2025

📲 You can test the changes from this Pull Request in Gravatar Android by scanning the QR code below to install the corresponding build.
App NameGravatar Android
Build TypeRelease
Commit9dace48
Direct Downloadgravatar-app-prototype-build-pr117-9dace48.apk

@hamorillo hamorillo marked this pull request as ready for review August 20, 2025 09:41
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both build types worked :shipit:

@hamorillo hamorillo merged commit 0c5e1d6 into trunk Aug 20, 2025
11 checks passed
@hamorillo hamorillo deleted the hamorillo/GRA-711 branch August 20, 2025 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants