This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the OAuth redirect URI handling from a custom scheme to Android App Links for improved security and user experience. The change enables automatic verification of deep links through the Android system.
- Adds
android:autoVerify="true"to the intent filter for automatic app link verification - Introduces proper URI path handling by adding
OAUTH_REDIRECT_URI_PATHmanifest placeholder - Refactors URI parsing logic to use Java's
URIclass instead of manual string splitting
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| loginUi/src/main/AndroidManifest.xml | Enables auto-verification and adds path parameter for app links |
| loginUi/build.gradle.kts | Refactors URI parsing to use proper URI class and extract path component |
| .configure | Updates pinned hash reference for configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
60ca9f0 to
9dace48
Compare
📲 You can test the changes from this Pull Request in Gravatar Android by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
approved these changes
Aug 20, 2025
Contributor
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Both build types worked ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates from the custom schema used for the OAuth redirection to use Android App Link.
The behaviour in the login flow should be identical from the users' point of view.
All the backend configuration is already done, so it should work smoothly.
Note: Don't forget to update your project secrets.
Testing Steps
❗ Test both debug and prototype build as we need to verify that both fingerprints are correct in the backend.