This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Merged
Conversation
AdamGrzybkowski
commented
Aug 19, 2025
| text = stringResource(R.string.about_app_dialog_privacy_settings), | ||
| modifier = Modifier.clickable { | ||
| context.openPrivacyPolicy() | ||
| onPrivacySettingsClicked() |
Contributor
Author
There was a problem hiding this comment.
❓ Should we invoke onDismiss as well here?
There was a problem hiding this comment.
We are not dismissing it for the delete flow so that I would say no. (Or, yes, if we apply the same approach to both flows).
AdamGrzybkowski
force-pushed
the
adam/GRA-743
branch
from
417a301 to
99e16ad
Compare
hamorillo
approved these changes
Aug 19, 2025
hamorillo
left a comment
hamorillo
left a comment
There was a problem hiding this comment.
Looks good!
❓Probably in a different PR, but should we use those privacy settings to disable the CrashLogging somehow? I would say we should also do the same in TracksTracker.
|
|
||
| @Composable | ||
| private fun PrivacySettingsCard( | ||
| settingTitle: String, |
There was a problem hiding this comment.
⛏️
Suggested change
| settingTitle: String, | |
| @StringRes settingTitle: Int, | |
| @DrawableRes settingIcon: Int, | |
| @StringRes settingDescription: Int, |
AdamGrzybkowski
force-pushed
the
adam/GRA-743
branch
2 times, most recently
from
e5a1091 to
7782cb9
Compare
📲 You can test the changes from this Pull Request in Gravatar Android by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
force-pushed
the
adam/GRA-743
branch
from
7782cb9 to
93af65f
Compare
This reverts commit 8720dc2.
AdamGrzybkowski
force-pushed
the
adam/GRA-743
branch
from
8720dc2 to
232a71e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Privacy Setting bottom sheet with an option to opt-out of analytics and/or Crashlytics.
The
PrivacySettingsStoragestores the information locally and will be cleared during logout.Testing Steps
...menu buttonThere's an extra commit 8720dc2 to test crash reporting.
Donebutton in the About app dialogDonebutton in the About app dialog