This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Merged
Conversation
hamorillo
reviewed
Aug 18, 2025
hamorillo
left a comment
hamorillo
left a comment
There was a problem hiding this comment.
Code changes look good!
changeThreshold, but we need to regenerate the screenshots.
|
Thinking about the threshold, an idea, if possible, could be to apply the threshold only to the "problematic" test, for example, using an annotation. Not related to this PR, just an idea to discuss. |
Contributor
Author
|
You're right. I've tried changing the threshold but other tests started to fail, but not the ones with the updated copy... |
AdamGrzybkowski
force-pushed
the
adam/GRA-744
branch
from
9ec8421 to
6ae4f6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tab rename: Share -> QR
Testing Steps