[Tooling] Add initial set of "frozen" strings for uploading to GlotPress#106
[Tooling] Add initial set of "frozen" strings for uploading to GlotPress#106
Conversation
iinm this will require you to redo the PR on wpcom that got reverted by the i18n team since (189316-ghe-Automattic/wpcom#issuecomment-1063794) after this PR lands and the strings exist in |
| <string name="login_profile_load_failure_cta">Try again</string> | ||
| <string name="login_profile_load_failure_alternative_cta">Try with another account</string> | ||
| <string name="login_authorization_denied_title">You need to log in to Gravatar.com</string> | ||
| </resources> No newline at end of file |
There was a problem hiding this comment.
nitpick and unrelated to this PR per se, but this "no newline at end of file" bothers me a bit, would be nice to add it not only to this file but also to the original file this frozen-strings is a copy of 🙃
|
@iangmaia Do we need to manually update the frozen strings whenever we change the original files? |
That's the idea if you want to have the strings uploaded to GlotPress. The idea is that once we have a regular release process with code freeze, a release branch, etc, we will "freeze" the strings automatically with automation. We could in theory upload the latest strings directly from the project without "freezing" them, but that isn't recommended when you have a code freeze process as you want to make sure the strings for the version being released won't change. |
3 participants
This PR is related to AINFRA-1034
Follow-up to 189316-ghe-Automattic/wpcom
Description
This PR simply copies the latest base strings from
homeUi/src/main/res/valuesandloginUi/src/main/res/valuesto the "frozen" strings paths underfastlane/resources/frozen-strings.This process should be automated once we introduce a code freeze routine, which will regularly copy the latest state of the strings when a release is started.
These strings will then be picked up by a cron job and will be uploaded as the latest source strings to GlotPress.
Testing Steps
Make sure the added strings are reflected in GlotPress once this PR is merged.