[Tooling] Add automation lane to fetch translations#105
Conversation
There was a problem hiding this comment.
(Nothing to change here, just me ranting)
That reminds me that this file (generated by our gp_download_translations helper from release-toolkit) is quite obsolete now…
- This was a file used by the WordPress Android project only, so that they can load it at runtime from their code to then have a custom language picker
- But now WPAndroid have migrated to getting rid to the custom, in-app locale picker and using more modern Android APIs that offers system-level locale switching (similar to iOS supporting setting the locale per app in System Settings)… so I don't think it's used in WPAndroid anymore
- And to my knowledge it's not used by any other project…
That shows the legacy of those helpers 😅
There was a problem hiding this comment.
Ahh thanks for the context 👍 I was curious why this file was being generated in the first place; just checked a few projects that still have it, and imagined it might still be used elsewhere 😅
|
Ooof we might want to update the Android linter settings to ignore |
iangmaia
force-pushed
the
iangmaia/add-fetch-translations-lane
branch
from
5311958 to
35b3e67
Compare
iangmaia
force-pushed
the
iangmaia/add-fetch-translations-lane
branch
from
35b3e67 to
56b55ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <string name="gravatar_tab_tap_for_options">Tryck för alternativ</string> | ||
| <string name="gravatar_tab_empty_avatars">Dina profilbilder kommer visas här</string> | ||
| <string name="gravatar_tab_previous_avatars">Tidigare profilbilder</string> | ||
| <string name="about_field_label_contact_email">E-post</string> |
Check warning
Code scanning / Android Lint
Unused resources Warning
| <string name="gravatar_tab_empty_avatars">Dina profilbilder kommer visas här</string> | ||
| <string name="gravatar_tab_previous_avatars">Tidigare profilbilder</string> | ||
| <string name="about_field_label_contact_email">E-post</string> | ||
| <string name="about_field_label_cell_phone">Telefon</string> |
Check warning
Code scanning / Android Lint
Unused resources Warning
2 participants
Fixes AINFRA-1033
Description
This PR adds the lane
download_translationsthat will fetch the translations from the Gravatar Android GlotPress projects (login-ui and home-ui) and add them to the project.I've also ran the lane for the first time to initially add the files (though I noticed the only language with actual translations was Swedish).
Testing Steps
bundle exec download_translations skip_commit:true