Skip to content

Conversation

@dalmouiee
Copy link
Member

@dalmouiee dalmouiee commented Dec 24, 2024

Hey @pchlap,

Just a few things I thought would be helpful for pydicer development moving forward, would love to hear your thoughts :)

  • Added a devcontainer with poetry and the dependencies all preinstalled as a post-step. Also comes with the jupyter extension installed
  • I've added test coverage reporting to indicate how much our tests are covering the code base. Interestingly, it's currently at 68% when run locally and with no exclusions
  • I am thinking of introducing mpy since we have stqarted to use types in Pydicer, but keen for your thoughts. We could add mypy checking to the pull requests github action along with a test coverage requirement of some percent (eg. 70-80%) before accepting new code. I'll have a go writing some more tests for pydicer and try getting it closer to 100% (no promises :P)

Thanks!

@pchlap
Copy link
Contributor

pchlap commented Dec 24, 2024

This is absolutely brilliant, thanks @dalmouiee! I will take a closer look at this a bit later, but I love that you've added these items. I also think running mypy as part of our GitHub pipelines is a great idea.

@dalmouiee dalmouiee marked this pull request as ready for review December 24, 2024 09:04
@dalmouiee dalmouiee requested a review from pchlap December 24, 2024 09:04
Copy link
Contributor

@pchlap pchlap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @dalmouiee. Really appreciate your efforts here. Left a couple of comments/questions but I think we can merge this whenever you're ready.

dalmouiee and others added 2 commits January 2, 2025 17:21
Co-authored-by: Phil Chlap <phillip.chlap@unsw.edu.au>
@dalmouiee dalmouiee merged commit 337d837 into main Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants