Version two #18
Merged
Version two #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and update tests accordingly. - Modified get_schema_version to use the instance schema if no schema is provided. - Added assertion in test_resolve_schema to verify the default schema version. - Refactored imports in test_validate for clarity and added a new test for resolved schema version.
- Replaced the Validate class with standalone functions for validating JSON objects and lists against a schema. - Introduced `validate_object`, `validate_list_dict`, and `pull_schema` functions to streamline validation processes. - Updated error handling to provide more informative messages when validation fails. - Added unit tests for new validation functions to ensure correctness and handle edge cases, including missing 'type' keys.
- Improved logging in the `validate_object` function to provide detailed debug information about validation processes, including error counts and specific validation errors. - Updated unit tests to reflect changes in validation logic, including the addition of a required `submitter_id` field and handling of validation errors for various object types. - Added a new test to capture a real-world validation error related to Agilent instruments.
- Introduced `version_two.ipynb` to demonstrate the schema validation process using the `gen3_validator` library. - Implemented logging for schema resolution and validation errors, including detailed output for instrument type validation. - Included example data for testing validation against the specified schema.
- Removed outdated code snippets and sections related to parsing and testing linkage. - Updated the usage examples for the `Validate` and `ValidateStats` classes to reflect the latest validation processes. - Added new examples demonstrating the validation of a list of dictionaries against a schema. - Improved clarity and organization of the documentation for better user understanding.
- Added a comprehensive section on validating JSON data objects against the gen3 JSON schema. - Included example code demonstrating schema resolution and validation processes using the gen3_validator library. - Provided example output for validation results to improve user understanding.
…and enhanced validation examples - Added a new "Quickstart" section to the README with example code for schema resolution and validation. - Updated the usage documentation to reflect changes in data structure and validation output. - Improved clarity of example data and validation results to aid user understanding.
…fined validation error messages - Set execution count for the code cell to 4. - Enhanced validation error messages to provide clearer feedback on schema validation failures, including specific invalid keys and types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.