Skip to content

Conversation

@minh-biocommons
Copy link
Collaborator

@minh-biocommons minh-biocommons commented Dec 19, 2025

Description

AAI-598: Refactor profile name, username & password change functionalities with better validation & error handling

Changes

  • Refactored & updated profile component change functionalities to use existing validators and validation service
  • Implemented consistent error handling

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

Copy link
Collaborator

@amandazhuyilan amandazhuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from me but will wait for @marius-mather 's final blessing

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@minh-biocommons minh-biocommons merged commit a306f51 into main Dec 19, 2025
8 checks passed
@minh-biocommons minh-biocommons deleted the profile-refactor branch December 19, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants