Skip to content

Conversation

@minh-biocommons
Copy link
Collaborator

@minh-biocommons minh-biocommons commented Apr 24, 2025

Description

AAI-181: Define and Create Route Definitions for User Endpoints

Changes

  • Update validator for user routes so that user routes don't require admin roles anymore
  • Define and implement all GET routes for user endpoints
  • Tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)

How to Test Manually (if necessary)

For manual testing, follow these steps:

  1. Create a .env and put in the vars referenced in the code, most of which can be found from Auth0 AAI Backend app
  2. Run the server
  3. Get an access token from logging into Auth0/using the Auth0 debugger and then use postman or similar tools and call the endpoints with the access token as an OAuth2.0 Bearer
  4. Inspect the response

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we should have a couple more schemas for our data so we always know what we expect (and any differences from that expectation show up clearly).

Great set of tests but I think they could be made a little bit clearer/easier to follow.

@amandazhuyilan amandazhuyilan mentioned this pull request May 10, 2025
4 tasks
@minh-biocommons minh-biocommons changed the title User Endpoints Implementation for GET routes User Endpoints Implementation May 12, 2025
marius-mather
marius-mather previously approved these changes May 13, 2025
Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great now, thanks! I updated the tests to use automatically generated data for the Auth0User where possible - hopefully now you can start to see that all the Pydantic model stuff I keep asking for can make things easier down the track rather than just being extra work!

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after a minor change

@marius-mather marius-mather merged commit 88018c5 into main May 13, 2025
1 check passed
@amandazhuyilan amandazhuyilan mentioned this pull request May 14, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants