-
Notifications
You must be signed in to change notification settings - Fork 0
User Endpoints Implementation #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and maintainability
…larity and coverage
… dependencies in tests
…ation and disable network calls in tests
…arity and remove network call disabling in tests
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think we should have a couple more schemas for our data so we always know what we expect (and any differences from that expectation show up clearly).
Great set of tests but I think they could be made a little bit clearer/easier to follow.
…ios and error handling
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great now, thanks! I updated the tests to use automatically generated data for the Auth0User where possible - hopefully now you can start to see that all the Pydantic model stuff I keep asking for can make things easier down the track rather than just being extra work!
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again after a minor change
Description
AAI-181: Define and Create Route Definitions for User Endpoints
Changes
Checklist
How to Test Manually (if necessary)
For manual testing, follow these steps: