-
Notifications
You must be signed in to change notification settings - Fork 0
AAI-175 AAI-180 Token Validator & Auth0 Management API integration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ate tests for private route permissions
…ironment variable settings
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great overall, just a few suggestions for code cleanups and things to fix up.
|
@amandazhuyilan I think this is good for review. I've made a few changes because I wanted to make sure we were describing our data with models/objects rather than just passing around dictionaries, so we now create a |
amandazhuyilan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great - only nit picking on the imports
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to merge now
Description
AAI-175: Create and test a decorator/FastAPI dependency that validates JWT tokens for AAI Backend
AAI-180: Integrate Auth0 Management API in aai-backend
Changes
Checklist
How to Test Manually (if necessary)
For manual testing, follow these steps: