Skip to content

Conversation

@minh-biocommons
Copy link
Collaborator

@minh-biocommons minh-biocommons commented Apr 11, 2025

Description

AAI-178: Setup aai-backend project with uv

AAI-179: Setup aai-backend project with FastAPI

This PR bootstraps the new aai-backend project using uv to ensure reproducible environments and modern Python dependency management. It includes a minimal FastAPI structure and test scaffolding to support upcoming features.

Changes

  • uv-based setup (e.g., uv venv, dependency management)
  • Basic FastAPI app structure (main.py, routers/, schemas/)
  • pytest-based test framework with sample test cases
  • Initial Pydantic schema definitions
  • Setup Github Actions workflow for tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)

@amandazhuyilan
Copy link
Contributor

Overall looks great! Would you also be able to set up running of the pytests with Github Actions in this pull request? Then we will have a properly set up project. Thank you!

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments on schemas, but we also want to make sure we're properly making use of uv to manage dependencies - this will make it easier to work with down the line. Try installing all deps via uv, and update the readme to reflect using uv to set up the virtual environment.

@marius-mather
Copy link
Collaborator

The most useful documentation is going to be here: Working on projects and here: Managing dependencies

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions to make sure we get started on the right foot with our dependency management

marius-mather
marius-mather previously approved these changes Apr 11, 2025
Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks!

@amandazhuyilan amandazhuyilan changed the title initialize FastAPI project with basic structure and tests AAI-179: initialize FastAPI project with basic structure and tests Apr 13, 2025
amandazhuyilan
amandazhuyilan previously approved these changes Apr 13, 2025
Copy link
Contributor

@amandazhuyilan amandazhuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 more small suggestions on the README - ready to go!

@amandazhuyilan amandazhuyilan self-requested a review April 13, 2025 23:33
@minh-biocommons minh-biocommons merged commit ec74153 into main Apr 13, 2025
1 check passed
@amandazhuyilan amandazhuyilan deleted the init-project branch April 17, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants