-
Notifications
You must be signed in to change notification settings - Fork 0
AAI-179: initialize FastAPI project with basic structure and tests #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Overall looks great! Would you also be able to set up running of the pytests with Github Actions in this pull request? Then we will have a properly set up project. Thank you! |
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments on schemas, but we also want to make sure we're properly making use of uv to manage dependencies - this will make it easier to work with down the line. Try installing all deps via uv, and update the readme to reflect using uv to set up the virtual environment.
|
The most useful documentation is going to be here: Working on projects and here: Managing dependencies |
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions to make sure we get started on the right foot with our dependency management
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, thanks!
amandazhuyilan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 more small suggestions on the README - ready to go!
5f74f21
Description
AAI-178: Setup aai-backend project with uv
AAI-179: Setup aai-backend project with FastAPI
This PR bootstraps the new
aai-backendproject usinguvto ensure reproducible environments and modern Python dependency management. It includes a minimal FastAPI structure and test scaffolding to support upcoming features.Changes
uv-based setup (e.g.,uv venv, dependency management)main.py,routers/,schemas/)pytest-based test framework with sample test casesChecklist