Skip to content

Conversation

@amandazhuyilan
Copy link
Contributor

Description

Currently when a new user registers for a SBP account, an email is sent to aai-dev@biocommons.org.au. This email should go to instead all SBP admins.

Changes

  • Add Platform.get_admins, mirroring group admin lookup, to fetch platform admin emails from Auth0 roles.
  • Update SBP registration flow to notify SBP admins instead of the hard-coded address.
  • Extend tests for SBP registration and platform admin email collection to cover the new behavior.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the unnecessary migration

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@amandazhuyilan amandazhuyilan merged commit 99214c4 into main Dec 18, 2025
5 checks passed
@amandazhuyilan amandazhuyilan deleted the send-email-to-sbp-admin branch December 18, 2025 23:54
@amandazhuyilan
Copy link
Contributor Author

This is the last pull request of 2025!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants