Skip to content

feat: backend validation of recaptcha during registration #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marius-mather merged 9 commits into from
Dec 16, 2025
Merged

feat: backend validation of recaptcha during registration #151

marius-mather merged 9 commits into from
Dec 16, 2025

Conversation

@marius-mather
Copy link
Collaborator

@marius-mather marius-mather commented Dec 12, 2025 •
edited
Loading

Description

We need to validate recaptcha responses on the backend, otherwise users can bypass our recaptcha check by sending direct requests.

Changes

  • Add method to validate a recaptcha token via the recaptcha API
  • Validate recaptcha during registration
  • Unit tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.
    NA: will be set in infra code

How to Test Manually (if necessary)

Run uv run pytest

@marius-mather marius-mather marked this pull request as ready for review December 12, 2025 03:55
@marius-mather marius-mather merged commit 6db2801 into main Dec 16, 2025
5 checks passed
@marius-mather marius-mather deleted the feat/validate-recaptcha branch December 16, 2025 00:40
marius-mather added a commit that referenced this pull request Dec 16, 2025
@marius-mather
Revert "Merge pull request #151 from AustralianBioCommons/feat/valida…
c724b94 
…te-recaptcha"

This reverts commit 6db2801, reversing
changes made to 237f9f8.
marius-mather added a commit that referenced this pull request Dec 16, 2025
@marius-mather
Merge pull request #153 from AustralianBioCommons/chore/revert-recaptcha
223231c 
Revert "Merge pull request #151 from AustralianBioCommons/feat/validate-recaptcha
marius-mather added a commit that referenced this pull request Dec 16, 2025
@marius-mather
Merge pull request #151 from AustralianBioCommons/feat/validate-recap…
9b57d82 
…tcha

feat: backend validation of recaptcha during registration
@marius-mather marius-mather mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minh-biocommons minh-biocommons minh-biocommons approved these changes

@amandazhuyilan amandazhuyilan Awaiting requested review from amandazhuyilan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marius-mather @minh-biocommons