Skip to content

Conversation

@marius-mather
Copy link
Collaborator

@marius-mather marius-mather commented Nov 28, 2025

Description

AAI-462: move the endpoint for requesting group access under the user router.

While doing this I noticed we had an outdated group approval endpoint, so I've removed it as part of this change.

Changes

  • Move /biocommons/groups/request to /me/groups/request
  • Remove outdated /biocommons/groups/approve endpoint
  • Remove biocommons_groups router now that it's unused
  • Move email functions to a common module

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

Run uv run pytest

@marius-mather marius-mather marked this pull request as ready for review November 28, 2025 05:10
Copy link
Contributor

@amandazhuyilan amandazhuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not be better - thanks for the change

@amandazhuyilan amandazhuyilan merged commit 0dc1d72 into main Nov 30, 2025
5 checks passed
@amandazhuyilan amandazhuyilan deleted the chore/refactor-group-request branch November 30, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants