Skip to content

Conversation

@amandazhuyilan
Copy link
Contributor

@amandazhuyilan amandazhuyilan commented Nov 25, 2025

Description

Remove sending emails to new users who has registered for a BioCommons account, and update sending emails to bundle admins upon new request.

Changes

  • Removed the admin notification helper so the BioCommons router no longer knows how to compose or enqueue the “New BioCommons User Registration” email
  • Update bundle requests to trigger admin emails. When someone registers for a bundle whose group membership isn’t auto‑approved (like TSI), the registration handler now looks up the group admins, composes the approval notice, and enqueues an email for each admin before committing the transaction.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to simplify this code a bit if possible - I know we can put in guards against every possible missing value, but it bloats out our code. Let's do some basic checks, but otherwise deal with issues when they actually arise

@amandazhuyilan amandazhuyilan force-pushed the remove-user-registration-email branch from 17a758e to 8beb5ef Compare November 25, 2025 23:24
Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@amandazhuyilan amandazhuyilan merged commit 1beb2bf into main Nov 25, 2025
4 checks passed
@amandazhuyilan amandazhuyilan deleted the remove-user-registration-email branch November 25, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants