-
Notifications
You must be signed in to change notification settings - Fork 0
fix: remove send_email flag and set up email queue in DB #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine for what it is (removing the config flag). Not sure if we want to work on a more robust email send service now, or leave that for later.
71e698a to
b8cdd70
Compare
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty good to me - I've flagged a few things you could consider changing but otherwise approved.
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Description
AAI-461: Remove unused
send_emailflag and set up email queue in DBChanges
Settings.send_emailflag so there’s no configuration gate keeping emails from being dispatched (we will do this through AWS IAM)EmailStatusEnum, the EmailNotification model with queue helpersChecklist
How to Test Manually (if necessary)
All updated and existing unit tests shall pass in CI!