Skip to content

Conversation

@amandazhuyilan
Copy link
Contributor

@amandazhuyilan amandazhuyilan commented Nov 19, 2025

Description

AAI-523: Un-revoke users from services via reattaching the related Auth0 roles

Changes

  • Platform approvals now load the Auth0 client dependency and reattach the platform role whenever a membership transitions back to approved, so an “unrevoke” via the approve endpoint restores Auth0 access
  • Added PlatformMembership.grant_auth0_role so the role assignment mirrors the existing revoke helper and centralizes the Auth0 role naming logic
  • Extended coverage to ensure the new helper behaves correctly and that the admin approval endpoint actually calls Auth0 to add the role

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

All new and old unit tests shall pass in CI.

Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think the endpoint should just return an error early if already approved.

@amandazhuyilan amandazhuyilan force-pushed the AAI-523-reinitiate-service-for-users branch from 4234715 to afc14be Compare November 21, 2025 00:12
Copy link
Collaborator

@marius-mather marius-mather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@amandazhuyilan amandazhuyilan merged commit 2aac7ec into main Nov 21, 2025
4 checks passed
@amandazhuyilan amandazhuyilan deleted the AAI-523-reinitiate-service-for-users branch November 24, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants