Skip to content

Conversation

@marius-mather
Copy link
Collaborator

@marius-mather marius-mather commented Nov 19, 2025

Description

Group admin roles should now be set automatically when the database is populated. But in order to update existing ones, we need an API endpoint (accessible only to BioCommons admins)

Changes

  • Add /biocommons-admin/groups/:group/set-admin-roles endpoint
  • Unit tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

Run uv run pytest

Copy link
Contributor

@amandazhuyilan amandazhuyilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues ...

@marius-mather marius-mather merged commit fb6b9e3 into main Nov 19, 2025
4 checks passed
@amandazhuyilan amandazhuyilan deleted the feat/group-role-update branch November 24, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants