AAI-461: send bundle approval emails when request is approved #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AAI-461: send bundle approval emails to users when request is approved by bundle admins
Changes
BackgroundTasks,Settings, andEmailService, returns the updated membershipfrom _approve_group_membership, and only schedulessend_group_membership_approved_emailwhensend_emailis enabled and the user has just transitioned to approvedBioCommonsgroup approval route to share the same behavior and introduced a reusablesend_group_membership_approved_emailhelper that builds the user-facing email with the bundle name and portal link so both admin and self-service approvals notify the user consistentlyChecklist