chore: remove BPA/Galaxy group fully from the code #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes all references to the bpa_galaxy group from the codebase, completing the cleanup of deprecated BPA/Galaxy group functionality.
- Removed
BPA_GALAXYenum value and its associated metadata fromGroupEnumandGROUP_NAMES - Updated all test cases to use generic group names or the TSI group instead of
bpa_galaxy - Removed
bpa_galaxyfrom admin router mappings and documentation
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| db/types.py | Removed BPA_GALAXY enum value and its entry from GROUP_NAMES dictionary |
| routers/admin.py | Removed bpa_galaxy from GROUP_MAPPING and updated filter description |
| tests/test_user.py | Replaced bpa_group references with generic other_group in profile tests |
| tests/test_biocommons_register.py | Updated comment to clarify test purpose (no bundle selection) |
| tests/test_admin.py | Removed test case for bpa_galaxy group filtering, updated filter options assertions, added mock for GroupEnum |
| tests/schemas/test_biocommons_schemas.py | Removed bpa_group membership creation from profile test |
| tests/scheduled_tasks/test_tasks.py | Refactored test to use parameterized groups enum for better testability |
| tests/datagen.py | Changed default bundle from bpa_galaxy to tsi |
| scheduled_tasks/tasks.py | Added groups parameter to populate_db_groups function for testability |
amandazhuyilan
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bpa_galaxygroup was still referenced in the code in a few places, completely remove it and update tests to not reference it.