Slice upload of comparison screenshots on HDB. #930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upload of comparison screenshots on HDB started to fail 2 weeks ago.
The reason appeared to be that the upload size is now limited to 100MiB.
https://hdbits.org/forums/viewtopic?topicid=81527&page=p1497682#1497682
This limitation seems to be set by CloudFlare and results in a silent failure of any upload whose size is larger than the limit.
The workaround was to slice the upload in smaller chunks.
The submitted PR proposes to make one upload to imgHDB per comparison group.
This has only been tested in debug mode so far, and worked successfully in debug mode.