Replace pkg_resources usage with plain file reading#32
Open
jobedom-scrapingbee wants to merge 4 commits intoAtuboDad:mainfrom
Open
Replace pkg_resources usage with plain file reading#32jobedom-scrapingbee wants to merge 4 commits intoAtuboDad:mainfrom
jobedom-scrapingbee wants to merge 4 commits intoAtuboDad:mainfrom
Conversation
1 task
|
@AtuboDad Any updates on this? |
|
@MJafarMashhadi , we ended up forking this repo and take over maintenance. If you are interested - check out https://github.com/tinyfish-io/tf-playwright-stealth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated and as of pip 24 (+ Python 3.12) its not working anymore at all. Replacing with a simple file read.
Fixes #22
This PR is a cleanup of @paveldudka PR #24 to get the fix merged as soon as possible.