Skip to content

Fix null pointer exception on motd fetch failure #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
in1tiate merged 1 commit into from
Jan 23, 2025
Merged

Fix null pointer exception on motd fetch failure #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lobby.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,10 @@ void Lobby::get_motd()
{
document = tr("Couldn't get the message of the day.");
}
ui_motd_text->setHtml(document);
if (ui_motd_text)
{
ui_motd_text->setHtml(document);
}
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/lobby.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class Lobby : public QMainWindow
QPushButton *ui_refresh_button;

// Serverinfo / MOTD Horizontal Row
QTextBrowser *ui_motd_text;
QPointer<QTextBrowser> ui_motd_text;

QLabel *ui_server_player_count_lbl;
QTextBrowser *ui_server_description_text;
Expand Down
Loading