Skip to content

Conversation

@WindzCUHK
Copy link
Contributor

@WindzCUHK WindzCUHK commented Apr 19, 2023

Description

as title

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Related issue/PR


Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

Signed-off-by: wfan <wfan@yahoo-corp.jp>
@WindzCUHK WindzCUHK changed the base branch from master to fix-vulnerability-in-regex April 19, 2023 09:21
Copy link
Contributor

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet x2

@mlajkim mlajkim merged commit aba05ed into fix-vulnerability-in-regex Apr 19, 2023
@mlajkim mlajkim deleted the setcap branch April 19, 2023 09:25
@WindzCUHK WindzCUHK mentioned this pull request Apr 20, 2023
16 tasks
WindzCUHK added a commit that referenced this pull request Apr 20, 2023
* feat: add maintainer jekim

* fix: indent

* fix: vulnerabilities in logic

* refactor: redundant ok bool var

* feat: buildRobustRegex()

* feat: logger with some refactors

* feat: install github.com/AthenZ/athenz-authorizer/v5

* feat: escape removed

* fix: logger with escape

* feat: apply assertion of athenz-authorizer

* fix: test strings

* fix: go 1.18 -> 1.20

* remove upx (#14)

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* test setcap (#15)

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix check cmd

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix: log message

* feat: WindzCHUK advice applied

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* feat: WindzCHUK advice applied

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* feat: WindzCHUK advice applied

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* feat: WindzCHUK advice applied

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* feat: WindzCHUK advice applied

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* refactor: redundant comments removed

* feat: apply given comment from wfan

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* feat: apply given comment from wfan

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* fix: message

* fix: message

* feat: WindzCHUK advice applied

Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>

* fix: debug logger

* feat: use Debugf

---------

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Aaron Jeongwoo Kim <53258958+mlajkim@users.noreply.github.com>
Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: wfan <wfan@yahoo-corp.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants