Open
Conversation
RichJackson
reviewed
Sep 12, 2024
docs/kazu_webservice.rst
Outdated
|
|
||
| .. code-block:: bash | ||
|
|
||
| git clone https://github.com/AstraZeneca/KAZU.git |
Collaborator
There was a problem hiding this comment.
rather than cloning the repo, perhaps it's better to install from pip, as the pip version is tested with the model pack version from the releases page? (main branch may have breaking changes with previous model pack release)
Collaborator
Author
There was a problem hiding this comment.
Sounds great! I just tested with my Mac OS environment and installation works well.
Get the version of Kazu in a dynamic manner, Add correct term (Swagger UI), Test env
RichJackson
force-pushed
the
docs_webserver
branch
from
4ad19ee to
942b192
Compare
Collaborator
|
@wonjininfo sorry for the delay in getting back to you. Looks good - just one minor suggestion. Also I rebased and fixed a minor formatting issue |
Collaborator
Author
|
Sounds good! I've modified the code to reflect your suggestion @RichJackson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a simple tutorial on how to run python -m kazu.web.server (i.e., host a REST API server).
This addresses issue #7.
Please feel free to review and provide any feedback, corrections, or modifications.