Fix and cleanup WFC3 package 2/2 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were all converted to .dat anyway, but for some reason the original .fits files were retained as well.
This required a fix in ScopeSim, which needs to be merged before this can be used, hence bumping the needs_scopesim.
teutoburg
added
instrument-specific
Addition of FVPSF and changes to pixel border effect might be responsible for ~0.2 % less flux than before.
oczoske
approved these changes
Jan 2, 2026
| --- | ||
| object: simulation | ||
| alias: SIM | ||
| name: WFC3_simulation_paramters |
Collaborator
There was a problem hiding this comment.
paramters -> parameters (fixed in #302 , which will probably cause a minor conflict)
| object: simulation | ||
| alias: SIM | ||
| name: WFC3_simulation_paramters | ||
| description: RC simulation paramters which need to change for a WFC3 |
github-project-automation
bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #295.
git mvthis time 🙃