Skip to content

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Nov 14, 2025

The original name "none" was converted to None somewhere. The new term "off" should be safe.

@oczoske oczoske requested a review from a team November 14, 2025 12:57
@oczoske oczoske self-assigned this Nov 14, 2025
@oczoske oczoske added the bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) label Nov 14, 2025
@oczoske oczoske linked an issue Nov 14, 2025 that may be closed by this pull request
@oczoske oczoske merged commit f15ba36 into main Nov 14, 2025
35 checks passed
@oczoske oczoske deleted the oc/wcu_lamp_none branch November 14, 2025 13:36
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.11%. Comparing base (0cc827a) to head (d89055d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/metis_wcu/metis_wcu.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files          69       69           
  Lines        8777     8777           
=======================================
  Hits         6593     6593           
  Misses       2184     2184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

METIS WCU lamp "none" not working properly

2 participants