Conversation
| type WeightPerGas = WeightPerGas; | ||
| type BlockHashMapping = pallet_ethereum::EthereumBlockHashMapping<Runtime>; | ||
| type CallOrigin = pallet_evm::EnsureAddressRoot<AccountId>; | ||
| type CallOrigin = EnsureEvmOrigin; |
There was a problem hiding this comment.
This should remain root - it's only related to who can call the actual pallet-evm extrinsics (which should be no one), it won't help with signature verification in pallet-ethereum.
The whole point of switching away from pallet-evm is to still emit relevant events for EVM indexers. It's all described in the BL ticket.
There was a problem hiding this comment.
This approach makes possible substrate users call EVM without any changes in frontier, didn’t it good enough?
There was a problem hiding this comment.
It's not, details are in the backlog item.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This PR was closed because it has been stalled for 14 days with no activity. |
3 participants
Pull Request Summary
Accompany PR for AstarNetwork/astar-frame#130
Check list