Remove native price usage in dAppStaking#1595
Conversation
ipapandinas
added
astar
|
/bench astar,shibuya,shiden pallet_inflation,pallet_dapp_staking |
|
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/22304207265. |
pallets/dapp-staking/src/types.rs
Outdated
| // It must always be at least 1 slot. | ||
| let base_number_of_slots = T::number_of_slots(P::get(), params.slot_number_args).max(1); | ||
| let new_number_of_slots = T::number_of_slots(native_price, params.slot_number_args).max(1); | ||
| let number_of_slots = T::number_of_slots(P::get(), FIXED_TIER_SLOTS_ARGS).max(1); |
There was a problem hiding this comment.
This is also redundant - there's nothing to calculate if it is fixed const.
It's better to just define a runtime const and use it here.
There was a problem hiding this comment.
I've created FIXED_NUMBER_OF_TIER_SLOTS runtime const and removed StandardTierSlots and its associated TierSlotsFunc trait for slot-number dynamic calculation. The generic type bounded to TierSlotsFunc was skipped in TiersConfiguration encoding, so no migration needed.
| let tier_thresholds_with_max = BoundedVec::<TierThreshold, TiersNum>::try_from(vec
Minimum allowed line rate is |
3 participants
Pull Request Summary
This PR removes native-price dependency from hot-path dApp staking tier recalculation.
slot_number_argsis kept for for now given the dAppStaking revamp rollout has already been applied on Shibuya/Shiden. It will be cleanup in the follow-up task #1589 with a dedicated migration.Check list**