Skip to content

proto addition from kamiden#2361

Open
Cooops wants to merge 1 commit intomainfrom
adding_topic_support_proto
Open

proto addition from kamiden#2361
Cooops wants to merge 1 commit intomainfrom
adding_topic_support_proto

Conversation

@Cooops
Copy link

@Cooops Cooops commented Feb 13, 2026

corresponding PR in kamiden, but tldr:

  1. Clients can now subscribe to specific event types (KILL, KAMI_CAST, MOVE, etc.) instead of receiving everything
  2. ~40-50% bandwidth reduction for clients that filter
  3. 100% backwards compatible (empty topics = all events, like before)

Summary by CodeRabbit

  • New Features
    • Added support for filtering stream events by topics. Users can now specify which topics to subscribe to, with backwards compatibility—omitting topics will stream all events.

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
kamigotchi-client Ready Ready Preview, Comment Feb 13, 2026 4:03pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

Adds an optional topics: string[] field to the StreamRequest interface in the protobuf definition, enabling topic-based filtering for stream subscriptions. Serialization methods (encode, decode, createBaseStreamRequest, fromPartial) updated to handle the new field.

Changes

Cohort / File(s) Summary
Proto Serialization
packages/client/src/clients/kamiden/proto.ts
Added optional topics: string[] field to StreamRequest interface with corresponding updates to encode, decode, createBaseStreamRequest, and fromPartial methods to serialize/deserialize topic strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • chlwys
  • Xenofluxx
  • JirAcheron

Poem

🐰 Hop, skip, and topics we go,
Streams now filter, high and low,
Empty arrays, sorted neat,
Proto fields make code complete! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'proto addition from kamiden' is vague and generic, using non-descriptive language that doesn't clearly convey the specific change being made. Revise the title to be more specific and descriptive, such as 'Add topic filtering support to StreamRequest' or 'Support topic-based event subscriptions in proto'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch adding_topic_support_proto

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants