Minor refactorings and documentation improvements #5
Conversation
Added some more comments.
Include Arduino.h, and use .ino extension.
high-order bits from the pins. This allows up to 256 logical groups for LEDs. Added more comments.
using macros.
|
After a quick test this code seems to break a couple functions, as in they no longer show up at all. After I get some free time I will look into this problem. I quite like what you did with the led mappings though, it is much more convenient. The default animations that no longer display are chaseTheDot() and fountian() |
|
It seems my pull request was premature. I was seeing some bugs too, but figured they were from my development branch, which uses different mappings. If you have time to test it on your working hardware, try reverting #f9c8575 in case I screwed up the bit mangling. |
Added keywords.txt for syntax highlighting. Moved charlieCube.ino to the examples subfolder
|
OK, I now have working hardware and I'm also seeing problems with chaseTheDot and fountain. It seems to be a problem with the drawLed function–I'll try to debug it over Christmas. |
Now uses PWMMMAX for full brightness, rather than 8 (right) and 255 (wrong) inconsistently. (cherry picked from commit c4a902b)
|
The problem was with some functions using a default brightness of 255 and some of 8. The current code uses 8-phase PWM for brightness, so I just changed everything to default to PWMMMAX (btw, extra M there?). Hopefully this will work with your hardware configuration. My 20-pin Charliecube is working great driven by an Arduino Mega. |
2 participants
I've made a number of minor changes and improvements to the code which you might be interested in. They shouldn't result in any functional changes. However, my own LED matrix is rigged differently from yours so I'm not able to test the changes definitively.
Changes include: