Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions transfer_queue/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ backend:
# ZMQ Server IP & Ports (automatically generated during init)
zmq_info: null

RayStore:
client_name: RayStorageClient

Comment on lines +27 to +29
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a short inline comment/header for this new RayStore block (matching the existing "# For SimpleStorage" section), and also update the earlier backend.storage_backend comment list to include RayStore so users discover the new backend option from the default config.

Copilot uses AI. Check for mistakes.
# For Yuanrong:
# TODO

Expand Down
2 changes: 2 additions & 0 deletions transfer_queue/storage/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from .managers import (
AsyncSimpleStorageManager,
MooncakeStorageManager,
RayStorageManager,
TransferQueueStorageManager,
TransferQueueStorageManagerFactory,
YuanrongStorageManager,
Expand All @@ -31,4 +32,5 @@
"AsyncSimpleStorageManager",
"MooncakeStorageManager",
"YuanrongStorageManager",
"RayStorageManager",
]
2 changes: 2 additions & 0 deletions transfer_queue/storage/managers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from .base import TransferQueueStorageManager
from .factory import TransferQueueStorageManagerFactory
from .mooncake_manager import MooncakeStorageManager
from .ray_storage_manager import RayStorageManager
from .simple_backend_manager import AsyncSimpleStorageManager
from .yuanrong_manager import YuanrongStorageManager

Expand All @@ -25,4 +26,5 @@
"AsyncSimpleStorageManager",
"YuanrongStorageManager",
"MooncakeStorageManager",
"RayStorageManager",
]
40 changes: 40 additions & 0 deletions transfer_queue/storage/managers/ray_storage_manager.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Copyright 2025 Huawei Technologies Co., Ltd. All Rights Reserved.
# Copyright 2025 The TransferQueue Team
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import logging
import os
from typing import Any

from transfer_queue.storage.managers.base import KVStorageManager
from transfer_queue.storage.managers.factory import TransferQueueStorageManagerFactory
from transfer_queue.utils.zmq_utils import ZMQServerInfo

logger = logging.getLogger(__name__)
logger.setLevel(os.getenv("TQ_LOGGING_LEVEL", logging.WARNING))


@TransferQueueStorageManagerFactory.register("RayStore")
class RayStorageManager(KVStorageManager):
"""Storage manager for Ray-RDT backend."""

def __init__(self, controller_info: ZMQServerInfo, config: dict[str, Any]):
client_name = config.get("client_name", None)

if client_name is None:
logger.info("Missing 'client_name' in config, using default value('RayStorageClient')")
config["client_name"] = "RayStorageClient"
elif client_name != "RayStorageClient":
raise ValueError(f"Invalid 'client_name': {client_name} in config. Expecting 'RayStorageClient'")
super().__init__(controller_info, config)
Comment on lines +32 to +40
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RayStorageManager introduces backend-specific config validation (defaulting/validating client_name) but there are no unit tests covering this behavior. Add a small test that constructs the manager (with controller connect mocked like other tests) to verify: (1) missing client_name is defaulted to RayStorageClient, and (2) a non-RayStorageClient value raises the expected ValueError.

Copilot uses AI. Check for mistakes.
Loading