This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Conversation
Author
|
|
ye-elvis
changed the title
linsannety
reviewed
Mar 16, 2021
Comment on lines
+66
to
+79
| // This is a labelled diagram of the table being tested. | ||
| // Notice the left border is not labelled. This is because | ||
| // all borders are referenced to the right of the cells. | ||
| // The (x, pos) indicate where the user is hovering and the resolved | ||
| // position. The initial editor state is a document with just an empty | ||
| // table. All cells are empty exce | ||
| // | ||
| // border 1 border 2 border 3 | ||
| // | |(1, 2) | ||
| // -------------------------------------- | ||
| // | |(2, 9) |(3, 14) |(4, 18) | ||
| // --------------------------- | ||
| // | |(5, 9) |(6, 24) |(7, 28) | ||
| // -------------------------------------- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an adoption of a fix from ProseMirror#79 but I included test to make sure that number of decorations are returning back properly.
Asana tasks:
https://app.asana.com/0/1117482789486653/1199983280453673/f
Relevant deployment: webapp (product + JS API)
Reason this is safe to merge before code review
N/A -- I plan to have this code reviewed before merging.