Modify audio playing logic for effects to work with custom hook#29
Open
qu1ll wants to merge 2 commits intoArvindParekh:mainfrom
Open
Modify audio playing logic for effects to work with custom hook#29qu1ll wants to merge 2 commits intoArvindParekh:mainfrom
qu1ll wants to merge 2 commits intoArvindParekh:mainfrom
Conversation
…racks, Effects, and more!
-useAudioPlayer.js -Effects.jsx -EffectCard.jsx added small error checking
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR title provides a concise description of my changes
Closes [Refactor] Shift the audio playing logic for the Effects to the useAudioPlayer custom hook #15
Audio playing logic successfully modified
Full functionality retained
Ability for more audio types
Please feel free to give me feedback on anything to change and/or tips