Skip to content

FIX: Added a bottom margin to tracks tag for design consistency#13

Open
GitGudCode440 wants to merge 1 commit intoArvindParekh:mainfrom
GitGudCode440:tracks-tag-adjustment
Open

FIX: Added a bottom margin to tracks tag for design consistency#13
GitGudCode440 wants to merge 1 commit intoArvindParekh:mainfrom
GitGudCode440:tracks-tag-adjustment

Conversation

@GitGudCode440
Copy link
Copy Markdown
Contributor

@GitGudCode440 GitGudCode440 commented May 3, 2024

Added margin of 5 to the bottom of tracks tag, to have some space between the track carousel and the tag. It aligns with the rest of the design where effects tag also have a margin of 5 between it, and effects carousel

@ArvindParekh
Copy link
Copy Markdown
Owner

Good spot, thanks for the PR! However, this makes the page scrollable, which I prefer not to happen. Maybe we can reduce the margin at both places?

@GitGudCode440
Copy link
Copy Markdown
Contributor Author

GitGudCode440 commented May 12, 2024

@ArvindParekh Isn't the page already scrollable by default? I checked it. Can you please clarify what you originally meant?

@ArvindParekh
Copy link
Copy Markdown
Owner

What I meant was that the current page layout fits the screen size perfectly, making it non-scrollable. However, increasing the margin pushes other elements down, causing the page to become scrollable. This adjustment feels somewhat unstable. Perhaps if we reduce the margin at both places, it should work.

@GitGudCode440
Copy link
Copy Markdown
Contributor Author

GitGudCode440 commented May 14, 2024

@ArvindParekh I just confirmed that the page is not scrollable under a standard resolution of 1920x1080. It was my weird monitor resolution(which is 1366x768) causing it to be scrollabe. But then again adding margin to the tag doesn't cause the page to become scrollable. It feels like your monitor resolution causes the page to be on the verge of not being scrollable, but it easily breaks when a small margin is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants