FIX: Added a bottom margin to tracks tag for design consistency#13
FIX: Added a bottom margin to tracks tag for design consistency#13GitGudCode440 wants to merge 1 commit intoArvindParekh:mainfrom
Conversation
|
Good spot, thanks for the PR! However, this makes the page scrollable, which I prefer not to happen. Maybe we can reduce the margin at both places? |
|
@ArvindParekh Isn't the page already scrollable by default? I checked it. Can you please clarify what you originally meant? |
|
What I meant was that the current page layout fits the screen size perfectly, making it non-scrollable. However, increasing the margin pushes other elements down, causing the page to become scrollable. This adjustment feels somewhat unstable. Perhaps if we reduce the margin at both places, it should work. |
|
@ArvindParekh I just confirmed that the page is not scrollable under a standard resolution of 1920x1080. It was my weird monitor resolution(which is 1366x768) causing it to be scrollabe. But then again adding margin to the tag doesn't cause the page to become scrollable. It feels like your monitor resolution causes the page to be on the verge of not being scrollable, but it easily breaks when a small margin is added. |
Added margin of 5 to the bottom of tracks tag, to have some space between the track carousel and the tag. It aligns with the rest of the design where effects tag also have a margin of 5 between it, and effects carousel