Handle Nested Iterators and In-Line For Block#30
Open
Teagan42 wants to merge 3 commits intoArtyMaury:masterfrom
Open
Handle Nested Iterators and In-Line For Block#30Teagan42 wants to merge 3 commits intoArtyMaury:masterfrom
Teagan42 wants to merge 3 commits intoArtyMaury:masterfrom
Conversation
Owner
|
Never used it inline indeed. Thanks for the contribution! |
|
Hi @Teagan42 and @ArtyMaury, I really need this feature. @Teagan42 could you update the change log with the changes you put int the PR comment, or give me access to your fork so I can do it for you? Thanks heaps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current REGEX pattern for matching Jinja
forblocks is too greedy. If a user defines aforblock that is in line with the body, the pattern will not appropriately match theforblock loop variable or the list variable.Example:
Changes
{% for x in item.value.requires %}