feat: Add type safety for model field filters #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compile-time type checking for `where`, `whereIn`, `whereNotIn`, and
`orderBy` methods to ensure only valid model field names are accepted.
This prevents runtime errors from typos in field names by catching them
at compile time. For example, `MenuItem.where('active', true)` will now
produce a TypeScript error if the field is actually named 'available'.
Closes #60
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compile-time type checking for
where,whereIn,whereNotIn, andorderBymethods to ensure only valid model field names are accepted.This prevents runtime errors from typos in field names by catching them at compile time. For example,
MenuItem.where('active', true)will now produce a TypeScript error if the field is actually namedavailable.Closes #60