add gradientLayer for fillColor#31
Open
dgutyanghs wants to merge 3 commits intoArthurGuibert:masterfrom
Open
Conversation
Owner
|
Thanks for the pull request! Is the gradient just for the background of the chart? Is it not something we want to be specific to the app? It wouldn't be hard to add the layer with a zPosition of -1 to be underneath the chart and then we wouldn't have to touch the FSLineChart class. |
Author
|
Sorry, I hadn't make myself clear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FSLineChart is awesome, very helpful in my App.
also, I add a gradient color for fill mode.
hope you enjoy!
Thanks!