This repository was archived by the owner on Apr 4, 2020. It is now read-only.
Add crypto_sign_ed25519_{sk,pk}_to_curve25519#17
Open
the-kenny wants to merge 5 commits intoArteMisc:masterfrom
Open
Add crypto_sign_ed25519_{sk,pk}_to_curve25519#17the-kenny wants to merge 5 commits intoArteMisc:masterfrom
the-kenny wants to merge 5 commits intoArteMisc:masterfrom
Conversation
…ypto_sign_ed25519_sk_to_curve25519
…nload. Tuples cannot be cached/reused in the same way atoms can.
ArteMisc
reviewed
Jun 11, 2019
Owner
|
Thanks for the addition, could you review the comment? Will merge the PR after. |
Co-Authored-By: Jan <ArteMisc@users.noreply.github.com>
Author
|
@ArteMisc sure! The backslash was purely accidental. Fixed! |
ArteMisc
reviewed
Jun 11, 2019
src/salty_nif.c
Outdated
|
|
||
| SALTY_FUNC(crypto_sign_ed25519_sk_to_curve25519, 1) DO | ||
| SALTY_INPUT_BIN(0, sk_ed25519, crypto_sign_ed25519_PUBLICKEYBYTES); | ||
| \ |
the-kenny
force-pushed
the
add-ed-to-curve-conversion-functions
branch
from
d04bfbe to
a8d6bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also includes a fix by @prook in #14 which crashes the Erlang VM in some error case.