Open
Conversation
It was possible to fill the disk partition by flooding auth.php with requests while the debug mode was on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some logins failed when auth.php did not submit over HTTPS. Some servers don't have it. TFA now works for sites with no SSL cert.
More importantly, I also noticed that while TFA_NGINX_DEBUG was enabled, it was possible for an attacker to fill the disk partition (using up all free space on the server) by flooding auth.php with requests. The debug.log is now limited to 100M in size. If it exceeds this size, it will be started over. There are definitely better ways to handle over-sized logs, such as rotating, but in the interest of closing the security hole, this is the most expedient solution.