Skip to content

Conversation

@ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Jun 19, 2025

Despite having #199 now, it still happens that token sequences get produced that are not allowed which breaks follow-up code of parsing which expects that everything that did not got parsed (a.k.a. the remaining sequence) is shorter than a complete tuple, i.e., 7 entries. Thus, we enforce the remaining to be shorter than 7 tokens directly in the parse method by trying to decode all chunks that grow up to 7 entries (instead of requiring that they also end with a none_label).

EDIT: Thinking about this again, it may be more correct to adjust the BinaryRelationEncoderDecoder.build_decoding_constraints to work with partial_encoding of length >= 7. This needs further investigation why this happens at all.

TODO:

  • decide if the approach mentioned as EDIT would be better
  • test in downstream projects

@ArneBinder ArneBinder added the bug Something isn't working label Jun 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (00c88ca) to head (61a1ff3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          68       68           
  Lines        6168     6168           
=======================================
  Hits         5906     5906           
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArneBinder ArneBinder marked this pull request as draft June 19, 2025 21:14
@ArneBinder ArneBinder changed the title BinaryRelationEncoderDecoder: never return remainings that are longer than 6 BinaryRelationEncoderDecoder.parse: never return remainings that are longer than 6 Jun 19, 2025
@ArneBinder ArneBinder force-pushed the BinaryRelationEncoderDecoder_fixed_length branch from 6e71f9a to 7e29a93 Compare June 24, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants