BinaryRelationEncoderDecoder.parse: never return remainings that are longer than 6
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite having #199 now, it still happens that token sequences get produced that are not allowed which breaks follow-up code of parsing which expects that everything that did not got parsed (a.k.a. the
remainingsequence) is shorter than a complete tuple, i.e., 7 entries. Thus, we enforce theremainingto be shorter than 7 tokens directly in the parse method by trying to decode all chunks that grow up to 7 entries (instead of requiring that they also end with anone_label).EDIT:
Thinking about this again, it may be more correct to adjust theThis needs further investigation why this happens at all.BinaryRelationEncoderDecoder.build_decoding_constraintsto work withpartial_encodingoflength >= 7.TODO: