Skip to content

Conversation

@ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Apr 27, 2025

IMPORTANT: All pie-modules releases that INCLUDE this PR should NEVER be used in combination with pytorch-ie WITHOUT ArneBinder/pytorch-ie#476!

remove pytorch-ie in favor of pie-core, i.e.,

  • remove model and taskmodule implementations
  • add annotations and documents from pytorch-ie
  • remove tokenize_document. This also removes the tokenize parameter from (document tokenization should happen in a dedicated preprocessing step):
    • RelationArgumentDistanceCollector
    • SpanCoverageCollector
    • SpanLengthCollector, and
    • completely removes TokenCountCollector
  • remove utils.tokenization including get_aligned_token_span
  • remove backwards compatibility re-exports:
    • utils.dictionary (including list_of_dicts2dict_of_lists and flatten_dict)
    • utils.hydra (including resolve_type and resolve_target)
  • cleanup dependencies
  • minor fixes
  • adjust the README.md

This implements #172.

This is the follow-up of #176.

More context: ArneBinder/pie-core#17

Follow-up: remove transformers dependency (i.e., remove tokenize_document)

@ArneBinder ArneBinder added the breaking Breaking Changes label Apr 27, 2025
@ArneBinder ArneBinder linked an issue Apr 27, 2025 that may be closed by this pull request
3 tasks
@ArneBinder ArneBinder marked this pull request as draft April 27, 2025 12:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2025

Codecov Report

Attention: Patch coverage is 97.23502% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.19%. Comparing base (d105e61) to head (6ddb6b4).

Files with missing lines Patch % Lines
src/pie_modules/annotations.py 96.77% 4 Missing ⚠️
src/pie_modules/documents.py 97.56% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   95.76%   97.19%   +1.43%     
==========================================
  Files          68       24      -44     
  Lines        6156     1999    -4157     
==========================================
- Hits         5895     1943    -3952     
+ Misses        261       56     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking Changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use pie-core instead of pytorch-ie

3 participants