-
Notifications
You must be signed in to change notification settings - Fork 2
remove pytorch-ie
#187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ArneBinder
wants to merge
11
commits into
main
Choose a base branch
from
remove-pytorch_ie
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
remove pytorch-ie
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 95.76% 97.19% +1.43%
==========================================
Files 68 24 -44
Lines 6156 1999 -4157
==========================================
- Hits 5895 1943 -3952
+ Misses 261 56 -205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 27, 2025
c2f2cd7 to
7ad5636
Compare
8212701 to
fbb52f7
Compare
…mplementations; add annotations and documents; minor fixes)
fbb52f7 to
d6916e0
Compare
ArneBinder
added a commit
to ArneBinder/pytorch-ie
that referenced
this pull request
Jul 19, 2025
This was referenced Jul 19, 2025
ArneBinder
added a commit
to ArneBinder/pytorch-ie
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All
pie-modulesreleases that INCLUDE this PR should NEVER be used in combination withpytorch-ieWITHOUT ArneBinder/pytorch-ie#476!remove
pytorch-iein favor ofpie-core, i.e.,pytorch-ietokenize_document. This also removes thetokenizeparameter from (document tokenization should happen in a dedicated preprocessing step):RelationArgumentDistanceCollectorSpanCoverageCollectorSpanLengthCollector, andTokenCountCollectorutils.tokenizationincludingget_aligned_token_spanutils.dictionary(includinglist_of_dicts2dict_of_listsandflatten_dict)utils.hydra(includingresolve_typeandresolve_target)This implements #172.
This is the follow-up of #176.
More context: ArneBinder/pie-core#17
Follow-up: remove
transformersdependency (i.e., removetokenize_document)