Skip to content

Conversation

@ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Jun 24, 2024

  • fix end indices (we used one token after the marker token before)
  • fix missed tokens when using partition annotations (any marker token at the beginning of a partition, i.e. sentence, was cut away)

EDIT: the fix for the decoding was outsourced to #102 which this is already rebased on

@ArneBinder ArneBinder added the bug Something isn't working label Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (a440655) to head (52a5d70).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          61       61           
  Lines        5127     5127           
=======================================
  Hits         4894     4894           
  Misses        233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder force-pushed the fix_re_span_pair_classification_tm branch 3 times, most recently from 35bb073 to 6d91d97 Compare June 27, 2024 08:23
@ArneBinder ArneBinder force-pushed the fix_re_span_pair_classification_tm branch from 6d91d97 to 52a5d70 Compare November 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants