Skip to content

Internal: General improvements [ED-13418] #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArmanPurtoian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Internal: General improvements [ED-13418] #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/controls/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ public static function get_image_title( $attachment ) {
public static function get_image_alt( $instance ) {
if ( empty( $instance['id'] ) ) {
// For `Insert From URL` images.
return isset( $instance['alt'] ) ? trim( strip_tags( $instance['alt'] ) ) : '';
return isset( $instance['alt'] ) ? trim( esc_attr( strip_tags( $instance['alt'] ) ) ) : '';
}

$attachment_id = $instance['id'];
Expand All @@ -402,7 +402,7 @@ public static function get_image_alt( $instance ) {
$alt = $attachment->post_title;
}
}
return trim( strip_tags( $alt ) );
return trim( esc_attr( strip_tags( $alt ) ) );
}

public function get_style_value( $css_property, $control_value, array $control_data ) {
Expand Down