corrected issue with minute and hour values#14
Open
ritvikRC wants to merge 1 commit intoArieleg:masterfrom
Open
corrected issue with minute and hour values#14ritvikRC wants to merge 1 commit intoArieleg:masterfrom
ritvikRC wants to merge 1 commit intoArieleg:masterfrom
Conversation
The problem with previous code was that the hours and minutes are passed in as float to string.format. string.format with "%02d" on float values rounds the values up or down to the nearest integer instead of rounding them down to the closest integer. The result of the previous code was that if the seconds value was greater than 30, the minutes value would be incorrectly incremented by 1. Similarly, if the minute value was greater than 30, the hour value would be incorrectly incremented by 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with previous code was that the hours and minutes are passed in as float to string.format.
string.format with "%02d" on float values rounds the values UP OR DOWN to the closest integer instead of rounding them ONLY DOWN to the closest integer.
The result of the previous code was that if the seconds value was greater than 30, the minutes value would be incorrectly incremented by 1.
Similarly, if the minute value was greater than 30, the hour value would be incorrectly incremented by 1.