Skip to content

Fix: Lints#104

Open
mberry wants to merge 1 commit intomasterfrom
lints-round1
Open

Fix: Lints#104
mberry wants to merge 1 commit intomasterfrom
lints-round1

Conversation

@mberry
Copy link
Member

@mberry mberry commented Oct 12, 2023

  • Removes unnecessary borrows
  • Adds parentheses for clarity
  • Use subtraction assignment
  • Remove unnecessary indexing

Removes unecessary borrows
Adds parentheses for clarity
Use subraction assignment
Remove unecessary indexing
@mberry
Copy link
Member Author

mberry commented Oct 12, 2023

So there seems to be an issue with cross compilation and cross-rs in general:

Status: Downloaded newer image for rustembedded/cross:mips64-unknown-linux-gnuabi64-0.1.15
   Compiling libc v0.2.149
   Compiling cfg-if v1.0.0
error[E0463]: can't find crate for `core`
  |
  = note: the `mips64-unknown-linux-gnuabi64` target may not be installed
  = help: consider downloading the target with `rustup target add mips64-unknown-linux-gnuabi64`

error[E0463]: can't find crate for `compiler_builtins`

Was going to leave this open for discussion for a week anyway so hopefully can sort out the CI issues by then.

@tarcieri
Copy link

@mberry MIPS was demoted to a Tier 3 target: rust-lang/rust#115218

I would suggest using powerpc-unknown-linux-gnu if you'd like to test against a 32-bit big endian Tier 2 target.

@mberry
Copy link
Member Author

mberry commented Oct 12, 2023

Thanks Tony, that's awesome, would really like to do the full spectrum for quick CI checks in cross.yaml but it's sometimes a moving target.

I'll hopefully try to adjust the scripts later today, Having a BE test is pretty much the important thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants