Open
Conversation
Member
mberry
commented
Oct 12, 2023
- Removes unnecessary borrows
- Adds parentheses for clarity
- Use subtraction assignment
- Remove unnecessary indexing
Removes unecessary borrows Adds parentheses for clarity Use subraction assignment Remove unecessary indexing
Member
Author
|
So there seems to be an issue with cross compilation and cross-rs in general: Status: Downloaded newer image for rustembedded/cross:mips64-unknown-linux-gnuabi64-0.1.15
Compiling libc v0.2.149
Compiling cfg-if v1.0.0
error[E0463]: can't find crate for `core`
|
= note: the `mips64-unknown-linux-gnuabi64` target may not be installed
= help: consider downloading the target with `rustup target add mips64-unknown-linux-gnuabi64`
error[E0463]: can't find crate for `compiler_builtins`Was going to leave this open for discussion for a week anyway so hopefully can sort out the CI issues by then. |
|
@mberry MIPS was demoted to a Tier 3 target: rust-lang/rust#115218 I would suggest using |
Member
Author
|
Thanks Tony, that's awesome, would really like to do the full spectrum for quick CI checks in I'll hopefully try to adjust the scripts later today, Having a BE test is pretty much the important thing here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.